Open
Conversation
Owner
Sosutha
commented
Sep 17, 2024
Sosutha
commented
- Added movh statement definition
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
2 times, most recently
from
10a1aac to
6a4c870
Compare
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
8 times, most recently
from
f41d23d to
06eb13a
Compare
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
14 times, most recently
from
9e9f473 to
a0e34e4
Compare
syogender
reviewed
Oct 9, 2024
backends/dpdk/dpdkHelpers.cpp
Outdated
| fields->push_back(new IR::StructField("upper_half", IR::Type_Bits::get(64))); | ||
| fields->push_back(new IR::StructField("lower_half", IR::Type_Bits::get(64))); | ||
| const IR::Type_Header *headerStruct = new IR::Type_Header(IR::ID("sandbox_header_t"), *fields); | ||
| auto name = new cstring("sandbox_header_t"); |
There was a problem hiding this comment.
can we use some name which are not valid identifier in P4 say starting with $
x=same tmp128_t
Owner
Author
There was a problem hiding this comment.
sandbox_header$_t
tmp128$_t
Are these fine?
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
4 times, most recently
from
30b7c86 to
21dd2e5
Compare
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
6 times, most recently
from
0b866d7 to
ae74cb8
Compare
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
9 times, most recently
from
45bbda9 to
d40ff2f
Compare
Signed-off-by: Sosutha Sethuramapandian <sosutha.sethuramapandian@intel.com> * Added movh statement definition * Added support for 128 bitwise operation * Added support for 128 bit equal and not equal operators. * Added support for 128 bit compliment operation * Updated testcase and output
Sosutha
force-pushed
the
dpdk_128_bit_support
branch
from
d40ff2f to
ce5265d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.